PlaylistStates should not allow completely clearing sort #38

Closed
opened 2021-11-10 11:14:09 -05:00 by anna · 1 comment
Owner

We're currently returning a list with an empty string, which confuses higher up layers

We're currently returning a list with an empty string, which confuses higher up layers
anna added this to the Emmental 2.8 milestone 2021-11-10 11:14:09 -05:00
anna added the
Kind/Bug
label 2021-11-10 13:55:06 -05:00
anna changed title from PlaylistStates should return an empty list when no sort fields have been set to PlaylistStates should not allow completely clearing sort 2021-11-10 13:55:51 -05:00
Author
Owner

It's worse than I initially thought. Completely clearing the sort order leads to SQLite complaining that we have an incomplete query since we don't pass anything to the "ORDER BY" clause. Fix this by setting tracks.trackid as a fallback sort order.

It's worse than I initially thought. Completely clearing the sort order leads to SQLite complaining that we have an incomplete query since we don't pass anything to the "ORDER BY" clause. Fix this by setting tracks.trackid as a fallback sort order.
anna closed this issue 2021-11-10 13:59:00 -05:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: anna/emmental#38
No description provided.