From 853594fc26fb67ece3d441679a65c2c6f9457527 Mon Sep 17 00:00:00 2001 From: Anna Schumaker Date: Thu, 9 Dec 2021 22:05:42 -0500 Subject: [PATCH] db: Remove indexes They aren't doing anything useful to help speed up sorting, so remove for now and reevaluate later Signed-off-by: Anna Schumaker --- db/album.py | 6 ------ db/artist.py | 6 ------ db/genre.py | 6 ------ db/track.py | 6 ------ db/user.py | 6 ------ 5 files changed, 30 deletions(-) diff --git a/db/album.py b/db/album.py index 0812792..67877b7 100644 --- a/db/album.py +++ b/db/album.py @@ -4,11 +4,6 @@ # +---------+----------+-----------+------+------+ # | albumid | artistid | plstateid | name | sort | # +---------+----------+-----------+------+------+ -# -# Index: album_index -# +-----------------------------+ -# | (artistid, name) -> albumid | -# +-----------------------------+ from gi.repository import GObject from . import disc from . import playlist @@ -51,7 +46,6 @@ class AlbumTable(playlist.ChildModel): " FOREIGN KEY(artistid) REFERENCES artists(artistid), " " FOREIGN KEY(plstateid) REFERENCES playlist_states(plstateid), " " UNIQUE(artistid, release, name))") - sql.execute("CREATE INDEX IF NOT EXISTS artist_index ON albums(artistid, name)") def do_factory(self, row): return Album(row) diff --git a/db/artist.py b/db/artist.py index 20eba3f..0875705 100644 --- a/db/artist.py +++ b/db/artist.py @@ -4,11 +4,6 @@ # +----------+-----------+------+------+ # | artistid | plstateid | name | sort | # +----------+-----------+------+------+ -# -# Index: artist_index -# +------------------+ -# | name -> artistid | -# +------------------+ from gi.repository import GObject from . import album from . import playlist @@ -40,7 +35,6 @@ class ArtistTable(playlist.Model): " name TEXT UNIQUE, " " sort TEXT, " " FOREIGN KEY(plstateid) REFERENCES playlist_states(plstateid))") - sql.execute("CREATE INDEX IF NOT EXISTS artist_index ON artists(name)") def do_factory(self, row): return Artist(row) diff --git a/db/genre.py b/db/genre.py index bf24e73..141d610 100644 --- a/db/genre.py +++ b/db/genre.py @@ -9,11 +9,6 @@ # +-----------------+ # | name -> genreid | # +-----------------+ -# -# Map: genre_map -# +---------+---------+ -# | genreid | trackid | -# +---------+---------+ from gi.repository import GObject from . import playlist from . import track @@ -49,7 +44,6 @@ class GenreTable(playlist.Model): " FOREIGN KEY(genreid) REFERENCES genres(genreid), " " FOREIGN KEY(trackid) REFERENCES tracks(trackid), " " UNIQUE(genreid, trackid))") - sql.execute("CREATE INDEX IF NOT EXISTS genre_index ON genres(name)") def do_drop(self): sql.execute("DROP TABLE genres") diff --git a/db/track.py b/db/track.py index 567e462..cd17e1d 100644 --- a/db/track.py +++ b/db/track.py @@ -6,11 +6,6 @@ # +---------+-----------+------------+---------+--------+--------+ # | number | playcount | lastplayed | length | title | path | # +---------+-----------+------------+---------+--------+--------| -# -# Index: track_index -# +-----------------+ -# | path -> trackid | -# +-----------------+ import datetime import pathlib from gi.repository import GObject @@ -135,7 +130,6 @@ class TrackTable(table.Table): " FOREIGN KEY(albumid) REFERENCES albums(albumid), " " FOREIGN KEY(discid) REFERENCES discs(discid), " " FOREIGN KEY(yearid) REFERENCES years(yearid))") - sql.execute("CREATE INDEX IF NOT EXISTS track_index ON tracks(path)") def do_factory(self, row): return Track(row) diff --git a/db/user.py b/db/user.py index 26ad4a7..53ee82e 100644 --- a/db/user.py +++ b/db/user.py @@ -4,11 +4,6 @@ # +------ ---+-----------+------+------+ # | playlistid | plstateid | name | sort | # +-------- -+-----------+------+------+ -# -# Index: playlist_index -# +--------------------+ -# | name -> playlistid | -# +--------------------+ from gi.repository import GObject from . import playlist from . import sql @@ -132,7 +127,6 @@ class UserTable(playlist.Model): " FOREIGN KEY(playlistid) REFERENCES playlists(playlistid), " " FOREIGN KEY(trackid) REFERENCES tracks(trackid), " " UNIQUE(playlistid, trackid))") - sql.execute("CREATE INDEX IF NOT EXISTS playlist_index ON playlists(name)") self.find("Collection", loop=True) self.find("Favorites")