From 7e09375325f0b9f5769497fd47da67b14fc63d03 Mon Sep 17 00:00:00 2001 From: Anna Schumaker Date: Fri, 13 May 2016 13:52:53 -0400 Subject: [PATCH] tests: Remove core/playlist.c test The playlist code is heavily tested by unit tests for the files in core/playlists/, so we no longer need to have a separate playlist test. Signed-off-by: Anna Schumaker --- tests/core/Sconscript | 1 + tests/core/playlist.c | 117 ------------------------------------------ 2 files changed, 1 insertion(+), 117 deletions(-) delete mode 100644 tests/core/playlist.c diff --git a/tests/core/Sconscript b/tests/core/Sconscript index 75a5353c..a2759115 100644 --- a/tests/core/Sconscript +++ b/tests/core/Sconscript @@ -34,6 +34,7 @@ res += SConscript("tags/Sconscript") core_objs += [ env.Object("../../core/queue.c") ] res += SConscript("playlists/Sconscript") +core_objs += [ env.Object("../../core/playlist.c") ] res += [ CoreTest("playlist") ] res += [ CoreTest("tempq") ] diff --git a/tests/core/playlist.c b/tests/core/playlist.c deleted file mode 100644 index e01fd20a..00000000 --- a/tests/core/playlist.c +++ /dev/null @@ -1,117 +0,0 @@ -/* - * Copyright 2013 (c) Anna Schumaker. - */ -#include -#include -#include -#include - -static void test_init() -{ - struct queue *q = playlist_get_queue(PL_SYSTEM, "Most Played"); - struct library *library; - GSList *list; - - idle_init_sync(); - tags_init(); - playlist_init(NULL); - while (idle_run_task()) {}; - - test_not_equal((void *)playlist_get_queue(PL_SYSTEM, "Favorites"), NULL); - test_not_equal((void *)playlist_get_queue(PL_SYSTEM, "Hidden"), NULL); - test_not_equal((void *)playlist_get_queue(PL_SYSTEM, "Unplayed"), NULL); - test_not_equal((void *)playlist_get_queue(PL_SYSTEM, "Most Played"), NULL); - test_not_equal((void *)playlist_get_queue(PL_SYSTEM, "Least Played"), NULL); - - test_not_equal((void *)q, NULL); - test_equal(queue_has_flag(q, Q_ENABLED), (bool)true); - test_equal(queue_has_flag(q, Q_REPEAT), (bool)true); - test_equal(queue_has_flag(q, Q_NO_SORT), (bool)false); - test_equal(queue_size(q), 0); - - list = q->q_sort; - test_equal(g_slist_length(q->q_sort), 3); - test_equal(GPOINTER_TO_INT(list->data), COMPARE_ARTIST); - list = g_slist_next(list); - test_equal(GPOINTER_TO_INT(list->data), COMPARE_YEAR); - list = g_slist_next(list); - test_equal(GPOINTER_TO_INT(list->data), COMPARE_TRACK); - - /* Add tracks to the collection. */ - library = library_find("tests/Music"); - track_add(library, "tests/Music/Hyrule Symphony/01 - Title Theme.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/02 - Kokiri Forest.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/03 - Hyrule Field.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/04 - Hyrule Castle.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/05 - Lon Lon Ranch.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/06 - Kakariko Village.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/07 - Death Mountain.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/08 - Zora's Domain.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/09 - Gerudo Valley.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/10 - Ganondorf.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/11 - Princess Zelda.ogg"); - track_add(library, "tests/Music/Hyrule Symphony/12 - Ocarina Medley.ogg"); - track_add(library, - "tests/Music/Hyrule Symphony/13 - The Legend of Zelda Medley.ogg"); -} - -static void test_add() -{ - struct track *track = track_get(0); - - test_equal(playlist_add(PL_SYSTEM, "Favorites", NULL), (bool)false); - test_equal(playlist_has(PL_SYSTEM, "Favorites", NULL), (bool)false); - - test_equal(playlist_has(PL_SYSTEM, "Favorites", track), (bool)false); - test_equal(playlist_add(PL_SYSTEM, "Favorites", track), (bool)true); - test_equal(playlist_has(PL_SYSTEM, "Favorites", track), (bool)true); - test_equal(playlist_size(PL_SYSTEM, "Favorites"), 1); - test_equal(playlist_add(PL_SYSTEM, "Favorites", track), (bool)false); - test_equal(playlist_size(PL_SYSTEM, "Favorites"), 1); - test_equal(playlist_add(PL_SYSTEM, "Favorites", track_get(1)), (bool)true); - test_equal(playlist_size(PL_SYSTEM, "Favorites"), 2); - - track = track_get(2); - test_equal(playlist_has(PL_SYSTEM, "Hidden", track), (bool)false); - test_equal(playlist_add(PL_SYSTEM, "Hidden", track), (bool)true); - test_equal(playlist_has(PL_SYSTEM, "Hidden", track), (bool)true); - test_equal(playlist_size(PL_SYSTEM, "Hidden"), 1); -} - -static void test_remove() -{ - struct track *track = track_get(0); - - /* The important thing here is that we don't crash */ - test_equal(playlist_remove(PL_SYSTEM, "Favorites", NULL), (bool)false); - - test_equal(playlist_size(PL_SYSTEM, "Favorites"), 2); - test_equal(playlist_has(PL_SYSTEM, "Favorites", track), (bool)true); - test_equal(playlist_remove(PL_SYSTEM, "Favorites", track), (bool)true); - test_equal(playlist_has(PL_SYSTEM, "Favorites", track), (bool)false); - test_equal(playlist_size(PL_SYSTEM, "Favorites"), 1); - test_equal(playlist_remove(PL_SYSTEM, "Favorites", track), (bool)false); - test_equal(playlist_size(PL_SYSTEM, "Favorites"), 1); - test_equal(playlist_remove(PL_SYSTEM, "Favorites", track_get(1)), (bool)true); - test_equal(playlist_size(PL_SYSTEM, "Favorites"), 0); - - track = track_get(2); - test_equal(playlist_size(PL_SYSTEM, "Hidden"), 1); - test_equal(playlist_has(PL_SYSTEM, "Hidden", track), (bool)true); - test_equal(playlist_remove(PL_SYSTEM, "Hidden", track), (bool)true); - test_equal(playlist_has(PL_SYSTEM, "Hidden", track), (bool)false); - test_equal(playlist_size(PL_SYSTEM, "Hidden"), 0); -} - -static void test_deinit() -{ - playlist_deinit(); - tags_deinit(); -} - -DECLARE_UNIT_TESTS( - UNIT_TEST("Playlist Initialization", test_init), - UNIT_TEST("Playlist Add Track", test_add), - UNIT_TEST("Playlist Remove Track", test_remove), - UNIT_TEST("Playlist Deinit", test_deinit), -);