diff --git a/gui/audio.c b/gui/audio.c index 86d39cc2..c4b4df40 100644 --- a/gui/audio.c +++ b/gui/audio.c @@ -9,10 +9,10 @@ static inline void __audio_set_label(const gchar *label, const gchar *size, - const gchar *prefix, const gchar *text) + const gchar *text) { - gchar *markup = g_markup_printf_escaped("%s%s", - size, prefix, text); + gchar *markup = g_markup_printf_escaped("%s", + size, text); gtk_label_set_markup(GTK_LABEL(gui_builder_widget(label)), markup); g_free(markup); } @@ -20,15 +20,15 @@ static inline void __audio_set_label(const gchar *label, const gchar *size, static inline void __audio_set_time_label(const gchar *label, unsigned int time) { gchar *str = string_sec2str(time); - __audio_set_label(label, "large", "", str); + __audio_set_label(label, "large", str); g_free(str); } static void __audio_load(struct track *track) { - __audio_set_label("o_title", "xx-large", "", track->tr_title); - __audio_set_label("o_artist", "x-large", "By: ", track->tr_artist->ar_name); - __audio_set_label("o_album", "x-large", "From: ", track->tr_album->al_name); + __audio_set_label("o_title", "xx-large", track->tr_title); + __audio_set_label("o_artist", "x-large", track->tr_artist->ar_name); + __audio_set_label("o_album", "x-large", track->tr_album->al_name); __audio_set_time_label("o_duration", track->tr_length); gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(gui_builder_widget("o_hide")), diff --git a/share/ocarina/ocarina6.glade b/share/ocarina/ocarina6.glade index cb07f1ab..0da73bc3 100644 --- a/share/ocarina/ocarina6.glade +++ b/share/ocarina/ocarina6.glade @@ -422,10 +422,12 @@ True False - + True False - vertical + start + 5 + True True @@ -435,9 +437,9 @@ True - True - True - 0 + 0 + 0 + 2 @@ -449,9 +451,8 @@ True - False - True - 1 + 1 + 1 @@ -463,9 +464,32 @@ True - True - True - 2 + 1 + 2 + + + + + True + False + start + system-users + + + 0 + 1 + + + + + True + False + start + media-optical + + + 0 + 2 diff --git a/tests/gui/audio.c b/tests/gui/audio.c index d14ff3e2..99f3ffd4 100644 --- a/tests/gui/audio.c +++ b/tests/gui/audio.c @@ -48,8 +48,8 @@ static void test_audio_seek(gint64 pos) static void test_audio() { - gchar *album, *artist, *duration; struct track *track; + gchar *duration; int argc = 0; gtk_init(&argc, NULL); @@ -71,18 +71,14 @@ static void test_audio() playlist_add(PL_HIDDEN, track); audio_load(track); - album = g_strdup_printf("From: %s", track->tr_album->al_name); - artist = g_strdup_printf("By: %s", track->tr_artist->ar_name); duration = string_sec2str(track->tr_length); test_equal(test_get_label_text("o_title"), track->tr_title); - test_equal(test_get_label_text("o_album"), album); - test_equal(test_get_label_text("o_artist"), artist); + test_equal(test_get_label_text("o_album"), track->tr_album->al_name); + test_equal(test_get_label_text("o_artist"), track->tr_artist->ar_name); test_equal(test_get_label_text("o_position"), "0:00"); test_equal(test_get_label_text("o_duration"), duration); test_equal(test_get_toggle_state("o_favorite"), (bool)true); test_equal(test_get_toggle_state("o_hide"), (bool)true); - g_free(album); - g_free(artist); g_free(duration); test_click_button("o_play");